doony icon indicating copy to clipboard operation
doony copied to clipboard

Improvements and some bug fixes to make the page compact and tidy.

Open baskaran-md opened this issue 10 years ago • 13 comments

When there are more jobs (150+) and mode executors, the current space and other CSS configuration makes the page cluttered. (So spacious!). This current fixes will provide proper spaces and fixes some mis-alignments on build history and home page. Also, added some effects to console output. (Inspired from https://github.com/djonsson/jenkins-atlassian-theme) PS: Each commit message should explain the changes clearly.

baskaran-md avatar Jan 25 '15 06:01 baskaran-md

If you wish to see the changes live, i can show you a small demo on our Continuous Integration System. Sorry, I cannot share it public.

baskaran-md avatar Jan 25 '15 07:01 baskaran-md

Tested against Jenkins 1.597

baskaran-md avatar Jan 25 '15 07:01 baskaran-md

home_page

baskaran-md avatar Jan 25 '15 07:01 baskaran-md

Build History build_history

baskaran-md avatar Jan 25 '15 07:01 baskaran-md

Console Output console_output

baskaran-md avatar Jan 25 '15 07:01 baskaran-md

thanks for this! the photos look great, but I am on my phone... will review the code tomorrow.

Kevin

Kevin Burke phone: 925.271.7005 | twentymilliseconds.com

On Sat, Jan 24, 2015 at 11:24 PM, Baskaran Deivasigamani < [email protected]> wrote:

Console Output [image: console_output] https://cloud.githubusercontent.com/assets/496507/5890765/24112e56-a420-11e4-9cb4-d5837c91d393.png

— Reply to this email directly or view it on GitHub https://github.com/kevinburke/doony/pull/85#issuecomment-71357729.

kevinburke avatar Jan 25 '15 07:01 kevinburke

Thank you.

baskaran-md avatar Jan 25 '15 19:01 baskaran-md

It's a really good start! Some things to clean up but we will get there. I made comments on the individual commits - looks like those comments are not showing up here.

kevinburke avatar Jan 26 '15 18:01 kevinburke

Thank you, @kevinburke. I will check those comments and get back to you soon.

baskaran-md avatar Jan 26 '15 19:01 baskaran-md

Ok sounds good! Please ping me again when you're ready for another look - I might miss it otherwise :)

Kevin Burke phone: 925.271.7005 | twentymilliseconds.com

On Mon, Jan 26, 2015 at 11:03 AM, Baskaran Deivasigamani < [email protected]> wrote:

Thank you, @kevinburke https://github.com/kevinburke. I will check those comments and get back to you soon.

— Reply to this email directly or view it on GitHub https://github.com/kevinburke/doony/pull/85#issuecomment-71516990.

kevinburke avatar Jan 27 '15 04:01 kevinburke

Any update here?

kevinburkeshyp avatar Feb 08 '15 01:02 kevinburkeshyp

I didn't get time to work on this.. Will spend some time during this week..

baskaran-md avatar Feb 09 '15 06:02 baskaran-md

This would be great to get merged :)

aehlke avatar Aug 20 '15 19:08 aehlke