Kevin Barabash

I haven't done any work on this since my last comment. I ended up switching to TypeScript for the project I was working on because there were other issues that...

A similar transform should be possible for cases where `fromString` uses values introduced by `parseJSON`. The definition of `fromString` would need to be augmented to take additional params and then...

Yes, exactly! I didn't realize it had a name. 😅

If we do, we can generate flow type definitions using https://github.com/joarwilk/flowgen.

After think about this some more, I think that staying with flow and generating TypeScript lib defs is probably the way to go. The API is pretty small so generating...

@Sibz thanks for the PR. Can you add some tests for this change? Also, I'm curious if this only handles a single level of nesting or multiple levels?

No rush, but this should have tests. You have a couple of test cases already in your commit message. I'm not very familiar with this repo, but I'm sure there...

I found a test for custom handler in generate_test.js that could be used as a starting point, see https://github.com/Khan/aphrodite/blob/master/tests/generate_test.js#L336-L350.

@jlfwong thanks for calling this out. Maybe we can include this in the package in an extensions folder. That would make it easier for people to opt in to this...

If we change the internal implementation of Aphrodite it will break that code. It seems like a generally useful function to have to support tooling. We could do it in...