cloudevents-ex icon indicating copy to clipboard operation
cloudevents-ex copied to clipboard

erlavro is a dependency of this project and it uses Rebar 2

Open brooksmtownsend opened this issue 2 years ago • 5 comments

dependency :erlavro is using Rebar 2, which is no longer maintained and no longer works in recent Erlang/OTP versions. Remove the :manager option or set it to :rebar3 instead

I get this warning when using this package

brooksmtownsend avatar Jun 13 '22 15:06 brooksmtownsend

I can fix it with an override, but it could easily be upgraded here

      {:erlavro, "~> 2.9.7", override: true, manager: :rebar3}

brooksmtownsend avatar Jun 13 '22 15:06 brooksmtownsend

Alternatively, if avrora was an optional dependency then this would only be needed if you brought in the optional avro dependencies

brooksmtownsend avatar Jun 13 '22 15:06 brooksmtownsend

Hi @brooksmtownsend, thanks for reporting. Happy to review a PR if you‘d like to contribute! Otherwise it’ll take some time for me to look into this, as I’m currently busy with other projects (which aren’t related to Elixir and Cloudevents)

kevinbader avatar Jun 14 '22 09:06 kevinbader

@kevinbader thanks for the quick response! I'd be happy to contribute, at the base level I can update the erlavro dependency and that should help everyone using this package.

I'm curious though, would you be fine with me making erlavro an optional dependency in addition to updating it? JSON is required, but we (and likely others) use this library without Avro and that would avoid bringing in extra dependencies (and for what it's worth I think we even got a build failure from one of them that we had to work around)

brooksmtownsend avatar Jun 16 '22 16:06 brooksmtownsend

I'm curious though, would you be fine with me making erlavro an optional dependency in addition to updating it? JSON is required, but we (and likely others) use this library without Avro and that would avoid bringing in extra dependencies (and for what it's worth I think we even got a build failure from one of them that we had to work around)

Sure, great idea!

kevinbader avatar Jun 16 '22 17:06 kevinbader