KlackEnder-Probe icon indicating copy to clipboard operation
KlackEnder-Probe copied to clipboard

[Feature Request] Use klickyprobe macros

Open Nighthawk3D opened this issue 2 years ago • 4 comments

Instead of using the macros included that aren’t really written well, utilize the existing work of the Klicky Probe macros.

This would allow for a much better user experience.

The existing macros could be updated to be much better if the rename_existing: function was utilized.

Nighthawk3D avatar Feb 16 '23 17:02 Nighthawk3D

Hey! There is something in the making to get the Klicky macros working with the Klack. Harry from my Discord spent some time to get all the changes done. I will link this in the instructions soon so you can chose if you want to use my very basic macros or the more advanced Klicky-Klack macros:

https://github.com/Harrypulvirenti/Klack-Probe-Macros

kevinakasam avatar Feb 17 '23 06:02 kevinakasam

I ran a diff on all of this... Its just renamed macros and the addition of one to handle manual screw adjust. Also removed z-tilt adjust which is more useful than manual screw adjust for some people. Why not just provide steps for setting up klickyprobe macros? This seems like overkill and just another set of macros to maintain vs just providing the config parts needed in the variables file.

Nighthawk3D avatar Feb 21 '23 21:02 Nighthawk3D

I recently switched from using the native KlackEnder macros to the Klicky-Probe ones, and I managed to make it work without any changes to the core macros, only the standard variables. My changes to the default Klicky-Probe variables are as follows:

  • variable_safe_z: Set to a safe height that doesn't interfere with the dock. 10 works for me on my setup.
  • variable_max_bed_y, variable_max_bed_x: Set to approximately the size of the bed, I used 230 for both.
  • variable_z_endstop_x, variable_z_endstop_x: Set to 0 if you use KlackEnder as the Z endstop.
  • variable_docklocation_x: Set to the X coordinates where your KlackEnder probe is picked up. I use 245.
  • variable_docklocation_y: Set to 0.
  • variable_docklocation_z: Set to a safe height that doesn't interfere with the dock. I use the same value as for variable_safe_z to avoid unnecessary Z moves.
  • Variable_dockmove_x: Set an X direction that moves the toolhead away from the dock to attach probe. I use -100.
  • Variable_dockmove_z: Set to a value where variable_docklocation_z - this = 2 (or similar low value above 0). I use -8. This lowers the probe correctly behind the dock with the default Klicky-Probe behavior and avoids scraping the nozzle on the bed when done.
  • Variable_attachmove_x: Set to a value high enough that the KlackEnder probe will move away from the dock. I use 40.

Obviously refer to your existing KlackEnder config and/or measurements for any specific values. The [bed_mesh] and [probe] sections additionally need to be moved to your printer.cfg and the KlackEnder config replaced with [include klicky-probe.cfg].

@kevinakasam If the above makes sense to document I am happy to open a PR.

Ordspilleren avatar Jun 12 '23 20:06 Ordspilleren

Hey @Ordspilleren That would be great! Feel free to add a Klicky Macro adaption block to the readme and then do a pull request :) Would be happy to merge it then

kevinakasam avatar Jun 19 '23 17:06 kevinakasam