Eureka
Eureka copied to clipboard
kevin218
Enable modeling of starspots with both Fleck and Starry
Exactly what the title says - Adds fleck for starspot modeling, modifies starry code to allow starspots (not recommended, very slow...). Adds a plot to show starspots for fleck. This addresses #605
@erinmmay, once this PR is ready for review, please mark it as such near the bottom of the page and request a review from Kevin and/or I.
Resolved conflicts and set fleck's "fast" option as the default (assumes stellar rotation is much longer than transit time and spots are stationary. user still has option to supply stellar rotation and calculate in "slow" mode). Pulling down the new version of the branch with conflicts resolved to test and then will remove "draft" status so it can be reviewed
I'm removing the draft status from this to expedite the process so it can be reviewed now, but I still have a couple tests to run (e.g. making sure this works with dynesty) before it should be merged
addressed comments and updated FleckModel.py to use new PlanetParams class. Fully tested with emcee and dynesty.
re: adding fleck to tests/NIR*_ecfs/ - it is too slow in my opinion to be a test model.
addressed minor parts. Working on the multi-white updates today, will request a review when it's ready
What’s going on with this PR? It looks like I signed off on it 3 weeks ago and nothing has happened since, but now there a bunch of conflicts.
@erinmmay still needed to address several things and then was going to request a review from me once it was ready
I've merged the changes in main into my starspots branch, have to go in and make a few more edits/tests. I will update and request a review when it's ready