WIP: Unhide a ValueError for deserialization errors.

Open vEpiphyte opened this issue 5 years ago • 5 comments

Closes #501

Removes reference to a dead link - OBE's #296

Dec 24 '19 19:12 vEpiphyte

@neozenith Opened this for discussion

Dec 24 '19 19:12 vEpiphyte

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@accffa8). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #506   +/-   ##
=========================================
  Coverage          ?   89.17%           
=========================================
  Files             ?       24           
  Lines             ?     1543           
  Branches          ?      211           
=========================================
  Hits              ?     1376           
  Misses            ?      138           
  Partials          ?       29

Impacted Files	Coverage Δ
vcr/errors.py	`100% <100%> (ø)`
vcr/serialize.py	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update accffa8...d35e73b. Read the comment docs.

Dec 24 '19 20:12 codecov-io

Thanks for following this up! I’ll have a look at it between now and New Years.

Dec 24 '19 22:12 neozenith

Actually I won’t have bandwidth to look at PRs until mid January when I’m finished my annual leave.

Dec 28 '19 05:12 neozenith

@neozenith Have you been able to look at this?

Apr 01 '20 14:04 vEpiphyte