vcrpy icon indicating copy to clipboard operation
vcrpy copied to clipboard

Add support for repeated get params in aiohttp

Open dedsm opened this issue 7 years ago • 5 comments

aiohttp supports receiving list of pairs or multidict in case you want to send repeated ids, this PR adds support for this.

dedsm avatar Jan 30 '18 11:01 dedsm

@dedsm thanks for your PR :slightly_smiling_face:

can you update your branch? this way we can follow the review/merge of this PR

lamenezes avatar May 02 '18 17:05 lamenezes

@lamenezes I guess you were referring to me to update the PR and not @carsonyl

I updated the PR and added the proposed changes.

I played around with dropping the fixed "<3" requirement for aiohttp in the tox.ini but I think it won't play nice with python < 3.6

dedsm avatar May 03 '18 08:05 dedsm

@lamenezes I guess you were referring to me to update the PR and not @carsonyl

Oops. I'm really sorry about that :sweat_smile: I should pay better attention when replying to multiple PRs

lamenezes avatar May 03 '18 12:05 lamenezes

@dedsm can you rebase your branch on master in order to resolve the conflicts ? I'll be happy to merge if the CI pass !

arthurHamon2 avatar Jul 02 '19 10:07 arthurHamon2

@arthurHamon2 I rebased it, hopefully it still stands

dedsm avatar Jul 02 '19 12:07 dedsm