vcrpy icon indicating copy to clipboard operation
vcrpy copied to clipboard

incompatibility with campaignmonitor/createsend

Open kevin1024 opened this issue 11 years ago • 2 comments

They are creating their own verifiedhttpsconnection, we would need to patch that as well.

https://github.com/campaignmonitor/createsend-python/blob/master/createsend/utils.py

Example traceback:

File "/Users/djgoku/development/virtualenv/please_work/lib/python2.7/site-packages/createsend/client.py", line 33, in campaigns
    response = self._get(self.uri_for("campaigns"))
  File "/Users/djgoku/development/virtualenv/please_work/lib/python2.7/site-packages/createsend/createsend.py", line 192, in _get
    return self.make_request(path=path, method="GET", params=params, username=username, password=password)
  File "/Users/djgoku/development/virtualenv/please_work/lib/python2.7/site-packages/createsend/createsend.py", line 159, in make_request
    c = VerifiedHTTPSConnection(parsed_base_uri.netloc)
  File "/Users/djgoku/lib/python2.7/httplib.py", line 1164, in __init__
    source_address)
TypeError: unbound method __init__() must be called with VCRHTTPConnection instance as first argument (got VerifiedHTTPSConnection instance instead)

kevin1024 avatar Sep 18 '14 03:09 kevin1024

seems like this could be dealt with in much the same way as https://github.com/kevin1024/vcrpy/issues/129

colonelpanic8 avatar Mar 24 '15 23:03 colonelpanic8

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale, would you mind closing it if it is no longer needed / relevant?

If I haven't heard anything in a week I'll mark it as closed as we have a lot of old tickets that need to be groomed to make it easier to see what is still relevant.

However if it is still needed, please feel free to re-open or create a new ticket.

Thanks! 🙏

neozenith avatar Jan 05 '20 22:01 neozenith