Kevin Bates

Results 510 comments of Kevin Bates

> Things like "entry points", KernelSpecManager and "subclass" sound like implementation details to me, and I think they are out of the scope of this JEP, or JEPs in general,...

Thanks for your response @hbcarlos. > I just wanted to clarify with you. In this JEP, we want to formalize the introduction of parameters to the Kernel Specs. We are...

> I do not know how to do this inside a trait validator, since AFAIK, traitlets do not support asynchronous validators. I just spent a couple of hours with this....

> This PR is supposed to move the code to have preferred_dir be a relative path (API path), so checking that is starts with the root dir runs counter to...

No worries at all @vidartf. I just pushed an import of `HTTPError` (since it had been removed in a "fix linting" commit separate from the one I reverted) and updated...

> This should at least get us back to having Windows pass but not *nix (which probably requires some better understanding as well) Using [this failure](https://github.com/jupyter-server/jupyter_server/actions/runs/3471762421/jobs/5801679509) as an example, why...

> Using [this failure](https://github.com/jupyter-server/jupyter_server/actions/runs/3471762421/jobs/5801679509) as an example, why would Windows be raising an HTTPError when the directory should clearly exist since its a parent of root_dir? I think the *nix...

I suspect this is because `stop_event.set()` is getting in the way. If you comment that out, you'll see your `Change.added`.

@shalberd - thank you for this pull request. I am surprised at how little changes there are and don't see any kind of Airflow version checking happening. With these changes,...

> I was under the impression that we were moving towards Elyra 4.0 where breaking changes were welcomed. Ok. That should be noted somewhere in this PR. I figured this...