image
image copied to clipboard
kevbaldwyn
Use base_path
In the code there are these comments...
// is there ant merit in this being base_path()? // if it was base_path() then any image on the filesystem could be served - is this actually desirable?
I suggest it would make sense to change this, as normally you'd want to be processing images which have been uploaded - and you wouldn't want to be uploading to the public folder.
Yeh, I've not really used this in a project yet, so still fiddling with useage. The config would need to be updated to be made clear. I'm happy to accept pull requests if you make any changes.
Ok great, never done a pull request before so I suppose it's time to learn!
I thought another nice idea might be to store predefined transformations in the config which can then just be referenced by name.
Sent from my iPhone
On 5 Dec 2013, at 02:14, Kevin Baldwyn [email protected] wrote:
Yeh, I've not really used this in a project yet, so still fiddling with useage. The config would need to be updated to be made clear. I'm happy to accept pull requests if you make any changes.
— Reply to this email directly or view it on GitHub.
Yeh that's not a bad idea.
On 5 December 2013 07:57, glennjacobs [email protected] wrote:
Ok great, never done a pull request before so I suppose it's time to learn!
I thought another nice idea might be to store predefined transformations in the config which can then just be referenced by name.
Sent from my iPhone
On 5 Dec 2013, at 02:14, Kevin Baldwyn [email protected] wrote:
Yeh, I've not really used this in a project yet, so still fiddling with useage. The config would need to be updated to be made clear. I'm happy to accept pull requests if you make any changes.
— Reply to this email directly or view it on GitHub.
— Reply to this email directly or view it on GitHubhttps://github.com/kevbaldwyn/image/issues/9#issuecomment-29877963 .
please change this line on "ImageServiceProvider.php" file: public function boot() { Config::package('kevbaldwyn/image', app_path() . '/config'); ...
