ihavecookies

ihavecookies copied to clipboard

- Added secure and samesite options to setCookie - Updated readme - Add minimal build tooling - Fix hardcoded secure/samesite behaviour

bpedersen2

Minor changes proposed by IDE (IntelliJ) Fix: closing tag in div#gdpr-cookie-message Change: Use same expiration (settings.expires) in cookie "cookieControlPrefs" than cookie "cookieControl"

jmlclosa

Please add an event, when the user clicks the button to show more settings.

JE4GLE

Added secure and samesite params to cookies

1

I also added some minimal build tooling (that you can leave out of course)

juhrlass

Separate buttons for "accept all" and "save"

1

Hello, I would suggest having separate labels (or buttons) for accepting all cookies and saving the settings made on the customize page. To my users it is confusing to have...

JE4GLE

Hello, I would suggest adding an option to change the id of the consent element from #gdpr-cookie-message to #_something-else_. This way, it would be harder for ad-blockers like to prevent...

JE4GLE

This pull request saves to the body element into a variable to prevent it from being loaded twice. Finally, an if statement is simplified. No big changes, just very small...

JE4GLE