reflexio
reflexio copied to clipboard
ketanhwr
The health circle around mother spaceship is not correctly centered
Fixed it. Also There seems to be a lot of duplicate functions on the levels.js. Can i have permission to clean out some more of the unused functions? Game works fine without them, maybe they are code people were trying to rewrite but never finished. Once I read and understand some more of the code, I will add some light documentation to them so future users will be able to read it easier.
I committed the change onto the masters branch, and i don't have permission to upload my own branch onto the repository in order to do a pull there. Not sure what I have to do to issue a pull request.
@Hn5624 check this: https://help.github.com/articles/creating-a-pull-request-from-a-fork/
Has this issue been resolved? The circle still isn't centered correctly in the game.
I fixed it and submitted the changes, you can load the game and you should be able to see if its fixed, basically the healthbar around your spacestation was off-centered.
If its still not fixed that means the creator didn't accept my changes or hasnt responded.
From: flyer2403 [email protected] Sent: Wednesday, January 10, 2018 5:06 AM To: ketanhwr/reflexio Cc: Ni, Henry; Mention Subject: Re: [ketanhwr/reflexio] The health circle around mother spaceship is not correctly centered (#36)
Has this issue been solved?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ketanhwr/reflexio/issues/36#issuecomment-356668565, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AewrMNkUKgFgEHr-k3zQlCnE8d9oup8Iks5tJO4pgaJpZM4RDCti.
Oh, anything i tried a "git push" it saids
"Permission to ketanhwr/reflexio.git denie to hn5624"
Are you suppose to give me permission before i can submit a push request, or is there another way to do it?
From: Ketan Gupta [email protected] Sent: Thursday, January 11, 2018 6:05:12 AM To: ketanhwr/reflexio Cc: Ni, Henry; Mention Subject: Re: [ketanhwr/reflexio] The health circle around mother spaceship is not correctly centered (#36)
@Hn5624https://github.com/hn5624 I didn't receive any pull request whatsoever.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ketanhwr/reflexio/issues/36#issuecomment-357011433, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AewrMFKM7Oivo80UhRblnoRLSqXpD5azks5tJk1YgaJpZM4RDCti.
@Hn5624 Oooooh, Okay, I know what you did. You cloned the repo instead of forking it. When you're contributing to a project you don't own, you need to make a fork of it so you that you have ownership (of a fork). Changes you make in your fork can reflected in the main repo (we'll call this upstream for now on) by making a pull request.
Now, a fix should be easy enough I believe;
- Make a new repository that has the same name as this one; leave it empty, it'll be filled in step three.
- Change the origin of the repository you worked on to match the one you made; something like
git remote set-url origin https://github.com/hn562/reflexio.git - From the repo that you worked on push to origin
git push origin; At this point you've populated your fork with the work you've done on the cloned upstream. - Now go to this repo from the web browser and click pull requests; then make a new pull request
- Make sure the base says 'ketanhwr/master' and the compare says 'hn5624/master'
- Lastly fill out the PR with the information suggested by the contributions guide and wait for it to be merged
Hope you're able to follow these instructions as I imagined you following them in my head, this too is my first contribution to an open source project. I'll be fairly active on github if you have and questions.
Yeah lol, github was extremely confusing to me at first, it makes much more sense now.
I think CMD prompts may be easier to use than the actual github desktop app.
From: p-shannon [email protected] Sent: Tuesday, January 16, 2018 4:31 AM To: ketanhwr/reflexio Cc: Ni, Henry; Mention Subject: Re: [ketanhwr/reflexio] The health circle around mother spaceship is not correctly centered (#36)
@Hn5624https://github.com/hn5624 Oooooh, Okay, I know what you did. You cloned the repo instead of forking it. When you're contributing to a project you don't own, you need to make a fork of it so you that you have ownership (of a fork). Changes you make in your fork can reflected in the main repo (we'll call this upstream for now on) by making a pull request.
Now, a fix should be easy enough I believe;
- Make a new repository that has the same name as this one; leave it empty, it'll be filled in step three.
- Change the origin of the repository you worked on to match the one you made; something like git remote set-url origin https://github.com/hn562/reflexio.git
- From the repo that you worked on push to origin git push origin; At this point you've populated your fork with the work you've done on the cloned upstream.
- Now go to this repo from the web browser and click pull requests; then make a new pull request
- Make sure the base says 'ketanhwr/master' and the compare says 'hn5624/master'
- Lastly fill out the PR with the information suggested by the contributions guide and wait for it to be merged
Hope you're able to follow these instructions as I imagined you following them in my head, this too is my first contribution to an open source project. I'll be fairly active on github if you have and questions.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ketanhwr/reflexio/issues/36#issuecomment-358020676, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AewrMIYN2BiphcJb6zr4iqkTo46_83NIks5tLM7lgaJpZM4RDCti.
Yeah I agree with that. Definitely do yourself a favor and get used to the command line interface from now on. Best of luck in open sourced world!
