Zbigniew Jędrzejewski-Szmek

Results 254 comments of Zbigniew Jędrzejewski-Szmek

I suspect the only explanation is some kind of memory corruption. manager_clear_jobs_and_units() does ``` while ((u = hashmap_first(m->units))) unit_free(u); ``` and unit_free() does ``` if (u->job) { Job *j =...

I'll unset the milestone then. There might be a bug, but with the currently available information we are never going to figure this out. Somebody who can reproduce the issue...

Based on the conversation during videoconf: ```console $ for i in $(systemctl --user show -P Id -t device); do systemctl --user show -p Wants,Requires,After,Before $i;done|sort|uniq -c 74 After= 74 Before=...

This looks reasonable. In principle we could do the filtering on the user side, but it's extremely convenient to do the filtering like this with a glob pattern, and to...

> Honestly I'm not seeing the problem here. The only one in my POV is that it introduces another debug interface whereas we could extend the existing one with a...

> Maybe such method could have been hidden like it's done for deprecated interfaces so it would have been more explicit. I don't think this would change anything. When I...

I'll set the `needs-rework` label because of the first comment. The second, please handle as you see best.

> Also, why does this return bulk data as text instead of memfd? We are repeating the same errors the original Dump() interface had? This was discussed in the review:...

@poettering could you take a look? It seems to be something about the core logic of homed…