Zbigniew Jędrzejewski-Szmek
Zbigniew Jędrzejewski-Szmek
I decided to take a simpler approach. This patch is rather messy. In particular, with the jinja2 templating, we end up with a bunch of empty lines when conditional content...
Can you describe the use cases more? This might help in deciding how it's implemented and if it should ever be the default.
Ooh, nice, under zsh, completions for `-d` and `-t` work perfectly. The same under bash. So I think this is functionally complete. I don't really have an opinion on verb...
I force-pushed with the changes that were requested. I want to get this merged… I thought it'd be a few small cleanups, but then it turns out to be more...
I undid the style change to `if`s.
OK, the tests pass and the comments have been addressed. Can we merge this and do follow-ups separately?
It is green, except for bogus comments from shellcheck that cannot be silenced. Oh, OK, I guess this requires a longer explanation: shellcheck could be silenced by inserting suppression comments...
https://github.com/koalaman/shellcheck/issues/2411
> The differential-shellcheck github action has an `exclude-path` option. We can use that. I looked at docs, but I didn't see it. That would work. > I added a commit...
Cool, thanks for testing. Fixed by #200.