kestra icon indicating copy to clipboard operation
kestra copied to clipboard

Feat/location by tenant

Open loicmathieu opened this issue 1 year ago • 3 comments

Allow configuring the internal storage at the tenant level.

The local storage has been updated to allow defining a different base path per tenant.

loicmathieu avatar Nov 23 '23 15:11 loicmathieu

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

55.6% 55.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Nov 24 '23 09:11 sonarqubecloud[bot]

@brian-mulier-p testing it from OSS can be hard because we always return an empty location from OSS and moreover testing that it uses different location is a per-storage validation (different base path, different bucket, ...).

The only thing I can think of is to spy the TenantService to check that it has been correctly called but, honestly, it has no real benefit.

I think this is again something that should be tested at a higher level (as we need to do for the tenant anyway)

loicmathieu avatar Nov 28 '23 16:11 loicmathieu

this isn't merged yet as it seems we weren't fully aligned on the specific implementation

@loicmathieu perhaps you can close the PR and we can plan a new implementation in 0.15.0? if it is easier to build on top of this PR, maybe we can switch to a draft status?

anna-geller avatar Jan 16 '24 21:01 anna-geller