kestra icon indicating copy to clipboard operation
kestra copied to clipboard

[UI] Disable save even after a cancelled change

Open brian-mulier-p opened this issue 1 year ago • 1 comments

Expected Behavior

We shouldn't be able to save a flow which has no change compared to the original one since it leads to confusion (did I change anything to the original flow ?)

Actual Behaviour

When first opening the flow, the save button is disabled but then if I type something and undo it, I'm back to the original flow and still I can save it again

Steps To Reproduce

  1. Open an existing flow
  2. Add a character
  3. Remove it
  4. You can save again your flow while there is no change

Environment Information

  • Kestra Version: 0.9.0-SNAPSHOT

Example flow

No response

brian-mulier-p avatar May 17 '23 13:05 brian-mulier-p

Should we duplicate the original flow YAML and compare it with current value to define if the button should be disabled instead of a simple boolean which never gets reset unless save ?

brian-mulier-p avatar May 17 '23 13:05 brian-mulier-p