Setting .Values.nameOverride has no impact on name

[jaredlander]

Expected Behavior

Looking at _helpers.tpl, it seems that setting nameOverride in values.yaml still does not result in the name being used for the various components.

{{/*
Create a default fully qualified app name.
We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
If release name contains chart name it will be used as a full name.
*/}}
{{- define "kestra.fullname" -}}
{{- $name := default .Chart.Name .Values.nameOverride -}}
{{- if contains $name .Release.Name -}}
{{- printf "%s-%s" .Release.Name .Component | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- printf "%s-%s-%s" .Release.Name .Chart.Name .Component | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}

I think that is because neither printf statement uses $name, only in the if statements.

Actual Behaviour

No response

Steps To Reproduce

No response

Environment Information

• Kestra Version: 0.22.2
• Helm Charts version: 0.22.2
• Docker Image version: 0.22.2