Maximilian Keßler

Results 10 comments of Maximilian Keßler

I spoke to duke, he thinks he's not gonna do this, so I'll give it a try. I got a first rebased version on https://github.com/kesslermaximilian/hanabi-live/tree/sudoku-variant which is at least running...

A few questions that you could maybe answer: - I suppose we want exactly the 20 five-suit variants combined with Sudoku. Potentially one could think about other modifiers like Funnels/Chimneys/TIIAH/etc,...

> > I suppose we want exactly the 20 five-suit variants > > To start with don't add any variants, just add 3-6 suits. Everything except 5 suits doesn't make...

We should close this now.

Note that you can log into infinite accounts from one browser window already How can you do that, without having to log out + in again?

Hm, but that breaks once you reload the page on any of these tabs (which sometimes you also need to do since the site hangs)

Yeah, binding it to tabs seems like a good idea, I like that.

Not the exact same error, but I just got this stacktrace while watching a 2p-NoVar game. I did not take any special actions except spectating. ![image](https://github.com/Hanabi-Live/hanabi-live/assets/82446011/b8e87163-c7d4-403a-bc11-de5da1804e4c) Clear Stacktrace: ``` TypeError:...

Probably this is a bug introduced in commit e74d6bdf here: https://github.com/Hanabi-Live/hanabi-live/blob/dd932e3a9b44719df2d4f2b7e28e9ab4c67e2388/server/src/table.go#L433-L443 I'm not really sure what it does, we first query the `t.Spectators` attribute (I suppose this holds a list...

I think the function here should definitely have the lock for the tables struct when being executed. I can see why we wouldn't care if the spectators list changes while...