kuinameplates2 icon indicating copy to clipboard operation
kuinameplates2 copied to clipboard

How to always show auras that would be purgable if i had a purge ability even though i don't

Open CollinCheng617 opened this issue 3 years ago • 6 comments

Hello! I know this is a strange request compared to what most people would need but I was wondering what code I need to modify or if there is already a modification we can make to the custom lua file to make it so that purgable auras are always displayed. At the moment they are only displayed for classes that have a purge ability. For example, on my Shadow Priest when i am facing a Resto druid in arena, I can see the purgable hots above their nameplate where as on my Balance Druid I cannot. I would like to always show purgable auras above the nameplate for all classes. Is there a modification I can make to do that? Please let me know and thank you for your time and everything you do for this addon!

CollinCheng617 avatar Feb 09 '22 22:02 CollinCheng617

A possible easy solution would be to make a modification in the code somewhere so the addon always thinks I’m a Blood Elf. Any chance you would be able to point me to where I could make that hack? Thank you so much in advance!

CollinCheng617 avatar Feb 09 '22 22:02 CollinCheng617

I would love this option as well. I made an attempt at picking through the code to try to go after a similar solution to Collin but could not find what I was looking for.

ehargarther avatar May 08 '22 16:05 ehargarther

Workaround is to replace return can_purge with return true in function AuraFrame_ShouldShowAura located in elements/auras.lua

ZdrzalikPrzemyslaw avatar May 28 '22 22:05 ZdrzalikPrzemyslaw

It looks like that makes it so it shows all buffs regardless of type are purgable, I am trying to only show Magic buffs at the moment. Do you know what change i should make to only get the Magic buffs?

CollinCheng617 avatar May 29 '22 06:05 CollinCheng617

Probably need to check https://wowpedia.fandom.com/wiki/API_UnitAura dispelType and show if is == 'Magic', unfortunately looks like you can't check for enrage type. The author doesnt pass dispelType to func AuraFrame_ShouldShowAura so need to overload function with an extra param and pass it there, then check for magic and ret true.

image

ZdrzalikPrzemyslaw avatar May 29 '22 13:05 ZdrzalikPrzemyslaw

I tried to add a dispelType param to the function and the callback for the cbr variable and added your code. Unfortunately it doesn't seem to work could you show the whole function?

CollinCheng617 avatar May 30 '22 06:05 CollinCheng617