gigatron-rom
gigatron-rom copied to clipboard
Pluggy Reloaded: merge back Contrib/pkupper/BabelFish into Utils/BabelFish
It is undesirable to have forks of BabelFish all over the place.
What is holding back merging right now is relatively small:
Adaptations
A different indentation style is used for the modified sections:
Spaces after keywords such as if
and while
A differences in naming convention. We also camelCase abbreviations:
GT1 --> Gt1 PS2 --> Ps2 Hence also: doSDFileTransfer --> doSdFileTransfer
The readNext() macro disappeared, and that causes a hangup when sendFile gets interrupted. The point of the macro is to provide an escape back into the main loop in case of an aborted file transfer. Now this situation requires a reset by the user and is confusing. That's undesirable and should be avoided by the system again.
Testing
When resolving the above, the result must be tested on the supported platforms: Arduino Uno, Arduino Micro, Arduino Nano --> On each of those, test all functionality
- sendFile.py
- the commands in the command line interface
- the function key shortcuts in Loader
- Saving and loading into Tiny BASIC
- Saving and loading into MS BASIC
On at least one of each, test
- Game controller pass through
- PS/2 interface
ATTiny85 --> The resulting object file shouldn't change a single byte
** Wrap-up **
With that, the Pluggy Reloaded config can be added as a supported configuration.