BukkitOldCombatMechanics icon indicating copy to clipboard operation
BukkitOldCombatMechanics copied to clipboard

Blocking not visible from 1.8 with ProtocolSupport

Open arceuss opened this issue 5 years ago • 2 comments

image using latest paper and protocolsupport

arceuss avatar Nov 20 '20 20:11 arceuss

Sorry but I haven't a clue what sort of wacky stuff ProtocolSupport, ViaVersion, ViaBackwards etc. do to work. They often conflict with OCM because it was never intended to work with 1.8 clients. Maybe at some point in the future I will have the time to investigate this.

kernitus avatar Nov 24 '20 10:11 kernitus

f

codergautam avatar Mar 26 '21 19:03 codergautam

You can bring up 1.8 sword blocking on protocolsupport with this plugin: https://www.spigotmc.org/resources/protocolsupportstuff.44527/

pabloalba16 avatar Jun 12 '23 16:06 pabloalba16

@pabloalba16 That looks doable, it seems that plugin modifies some packets for certain clients so that 1.8 clients see people blocking. It should be possible to integrate that into OCM.

kernitus avatar Jun 14 '23 14:06 kernitus

that would be amazing! thank you so much!

pabloalba16 avatar Jun 14 '23 16:06 pabloalba16

@pabloalba16 That looks doable, it seems that plugin modifies some packets for certain clients so that 1.8 clients see people blocking. It should be possible to integrate that into OCM.

I am experiencing a similar issue, players on 1.8 clients cant see people drawing back their bows to shoot. This also occasionally causes the player to become invisible. Would it be possible to integrate a similar packet fix for bows as you are planning to do for sword blocking here? Thanks!

NotAlexNoyle avatar Jun 16 '23 09:06 NotAlexNoyle

@NotAlexNoyle That doesn't sound like OCM is the cause of that problem, so it would not be possible to fix that from this plugin.

kernitus avatar Jun 16 '23 09:06 kernitus

@NotAlexNoyle Are you using ProtocolSupport or ViaRewind to bring back 1.8 support?

pabloalba16 avatar Jun 16 '23 13:06 pabloalba16

@NotAlexNoyle Are you using ProtocolSupport or ViaRewind to bring back 1.8 support?

ViaRewind. Would I be correct in assuming that this issue is applicable for ViaRewindLegacySupport?

NotAlexNoyle avatar Jun 16 '23 13:06 NotAlexNoyle

ViaRewindLegacySupport does not claim to fix it in their spigot description. If players become invisible, that's ViaRewind issue. It does not seem like they have implemented the draw back for bows. ProtocolSupport has it but it is discontinued and incompatible with some anticheats so it is not viable

pabloalba16 avatar Jun 16 '23 13:06 pabloalba16

https://github.com/ViaVersion/ViaRewind/issues/64

pabloalba16 avatar Jun 16 '23 13:06 pabloalba16

This is actually not OCM's responsibility. All OCM does is give the player a shield. If ViaRewing/ViaBackwards etc. are able to show a 1.8 client who is sword-blocking as holding a shield, then they should also be able to show a 1.9+ client who is shield-blocking as sword-blocking. If that is not currently the case, that is a feature request for those plugins.

kernitus avatar Dec 26 '23 17:12 kernitus