Ritesh H Shukla

Results 133 comments of Ritesh H Shukla

thanks @symious will get this reviewed

cc @duongkame @aswinshakil @tanvipenumudy

Instead of adding a cache, which can lead to inconsistent reads, we should walk over the client code to see why the additional read volume and bucket calls were added....

cc @tanvipenumudy can you please take a look as well?

@muskan1012 can you take a[ look at `captureLatencyNs` used](https://github.com/apache/ozone/blob/9a6ece27e7907f06a48ceb55406c2e196977db4c/hadoop-hdds/common/src/main/java/org/apache/hadoop/util/MetricUtil.java#L40) in https://github.com/apache/ozone/pull/3780 for capturing the latency of operation call. This will help avoid the need to capture start and stop time...

If I understand this correctly, currently even if Vault is used as the store for secret, the act of generating a secret and storing it done via Ratis. This also...

@k5342 do you plan to continue with this PR? Can you please rebase and address the review comments?

+1 We need to root cause the divergence. This is a good hack to reset and fix the inconsistency but there might be a larger problem at hand.