infix icon indicating copy to clipboard operation
infix copied to clipboard

Incorrect target file for gen-version in the failure() function

Open axkar opened this issue 1 year ago • 1 comments

Current Behavior

In the failure() function, the gen-version command is currently writing its output to the wrong directory. The command:

gen-version >"$FACTORY_D/20-version.json"

is targeting the $FACTORY_D directory.

Expected Behavior

It should instead be targeting the $FAILURE_D directory, like the other commands in this function.

gen-version >"$FAILURE_D/20-version.json"

Steps To Reproduce

No response

Additional information

No response

axkar avatar Aug 15 '24 14:08 axkar

Nice catch, confirmed!

troglobit avatar Aug 15 '24 18:08 troglobit

We didn't cover this one in today's inbox meeting, but I'm assigning this one to you, @ahmkar94. Just make sure to include the "Fixes #562" line somewhere in the commit message for this fix :sunglasses:

troglobit avatar Aug 22 '24 20:08 troglobit

We didn't cover this one in today's inbox meeting, but I'm assigning this one to you, @ahmkar94. Just make sure to include the "Fixes #562" line somewhere in the commit message for this fix 😎

Did that yesterday in the ongoing PR #569 😎

axkar avatar Aug 23 '24 07:08 axkar