dotenv-flow icon indicating copy to clipboard operation
dotenv-flow copied to clipboard
verified publisher icon kerimdzhanov

Add exports field

Open perrin4869 opened this issue 3 years ago • 1 comments

This fixes import dotenv-flow/config from inside an mjs module

perrin4869 avatar Apr 25 '22 08:04 perrin4869

Closes https://github.com/kerimdzhanov/dotenv-flow/issues/56

perrin4869 avatar Sep 05 '22 07:09 perrin4869

Hi @perrin4869,

Thanks a lot for the PR! That makes total sense.

The only question I am thinking about is how can we make sure that it won't break existing Node.js's require() behavior in different versions/transpilers/environments? And maybe for the future as well, when we will be making some related changes to package.json, how can we make sure that we won't break this new TS/ES6's import behavior?

I am thinking of some kind of CI test for it 🤔, any ideas?

kerimdzhanov avatar Aug 14 '23 17:08 kerimdzhanov

I added some tests here! Not very thorough though 😅

perrin4869 avatar Aug 15 '23 02:08 perrin4869

Hi @perrin4869, could you please rebase? Feel free to rewrite with your own version of yarn.lock, I am going to update all the dependencies in a separate commit.

kerimdzhanov avatar Aug 15 '23 18:08 kerimdzhanov

All good, no worries. I've figured out how can I rebase myself 😅

✅ Merged as commit 352888b.

Thanks a lot for the PR!

kerimdzhanov avatar Aug 16 '23 02:08 kerimdzhanov