keras icon indicating copy to clipboard operation
keras copied to clipboard

Add f-string format and check with flynt for the whole codebase

Open edumucelli opened this issue 2 years ago • 4 comments

Hi,

In order to standardize the f-string usage of the whole codebase I have added flynt to the format and lint scripts. This avoids multiple "f-string" one line pull requests and makes it go into the github check process to avoid introduction of old style string formatting once merged.

The reformatting was all made by flynt. I am not using flynt's --aggressive to avoid "conversions with potentially changed behavior".

edumucelli avatar Aug 05 '22 21:08 edumucelli

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 05 '22 21:08 google-cla[bot]

Thanks for the PR. I would prefer updating the codebase without adding a regular check.

Thanks for the prompt review. I have made the required changes, i.e., removed flynt from the shell/lint.sh and shell/format.sh and from the project requirements.txt.

edumucelli avatar Aug 08 '22 19:08 edumucelli

This branch has conflicts that must be resolved

Please rebase to fix conflict.

fchollet avatar Aug 09 '22 04:08 fchollet

This branch has conflicts that must be resolved

Please rebase to fix conflict.

Sure, done.

edumucelli avatar Aug 09 '22 08:08 edumucelli