keras icon indicating copy to clipboard operation
keras copied to clipboard

Raise ValueError if reducing axis dimension is 0

Open old-school-kid opened this issue 2 years ago • 7 comments

Fixes the issue #16941

The solution notebook

old-school-kid avatar Jul 04 '22 16:07 old-school-kid

@old-school-kid Can you please check @fchollet's comments and keep us posted ? Thank you!

gbaned avatar Jul 13 '22 06:07 gbaned

@old-school-kid the PR appears empty at this time. Do you have any update?

fchollet avatar Jul 20 '22 18:07 fchollet

@fchollet can you take a look now? TIA

old-school-kid avatar Jul 23 '22 09:07 old-school-kid

@old-school-kid Can you please check @fchollet's comments and keep us posted ? Thank you!

gbaned avatar Jul 30 '22 04:07 gbaned

@fchollet Sorry for the extreme delay, had some academic commitments. Added two checks each for GlobalAveragePooling and GlobalMaxPooling for 1D and 3D (with keepdims=True). Please let me know if I should add more tests.

old-school-kid avatar Sep 24 '22 10:09 old-school-kid

Also keras-team/tf-keras#471 has a similar issue when 1 dimension is empty in case of Conv Transpose layers. I guess a similar solution could work for that too?!

old-school-kid avatar Sep 24 '22 10:09 old-school-kid

@gbaned Would you please remove the awaiting response from contributor label.? TIA

old-school-kid avatar Sep 27 '22 18:09 old-school-kid

@fchollet, please take a look for this PR again.

qlzh727 avatar Dec 01 '22 02:12 qlzh727

Hi @fchollet Can you please review this PR ? Thank you!

gbaned avatar Dec 16 '22 13:12 gbaned

Hi @fchollet Could you please give it a look? TIA

old-school-kid avatar Jan 12 '23 13:01 old-school-kid

Sorry to bug again @fchollet ! But would you please take a look at the PR? TIA

old-school-kid avatar Feb 07 '23 13:02 old-school-kid

cc @fchollet

jbischof avatar Mar 02 '23 18:03 jbischof

Hi @fchollet Can you please review this PR ? Thank you!

gbaned avatar Mar 21 '23 17:03 gbaned