keras icon indicating copy to clipboard operation
keras copied to clipboard

Add GeM layer

Open innat opened this issue 3 years ago • 3 comments

Close https://github.com/keras-team/keras/issues/16702

innat avatar Jul 03 '22 17:07 innat

The 4th page of the paper states

The pooling parameter pk can be manually set or learned since this operation is differentiable and can be part of the back-propagation.

I think we can set the 'power' as a learnable parameter instead of treating it as a hyperparameter, which is again demonstrated in the experiments in the paper itself.

old-school-kid avatar Jul 04 '22 18:07 old-school-kid

The 4th page of the paper states

The pooling parameter pk can be manually set or learned since this operation is differentiable and can be part of the back-propagation.

I think we can set the 'power' as a learnable parameter instead of treating it as a hyperparameter, which is again demonstrated in the experiments in the paper itself.

@old-school-kid I see your point. We can set manually or as a learnable parameter. But I think, we need to select one option here. I mostly followed tf/models, and tf/similarity approaches, and they both choose manual passing.

innat avatar Jul 07 '22 00:07 innat

IMO it seems fine to keep power as a static constructor argument.

fchollet avatar Jul 20 '22 17:07 fchollet

Hi @qlzh727 / @fchollet Any update on this PR? Please. Thank you!

gbaned avatar Dec 16 '22 13:12 gbaned

Hi @qlzh727 / @fchollet Any update on this PR? Please. Thank you!

gbaned avatar Mar 21 '23 17:03 gbaned