keras-preprocessing icon indicating copy to clipboard operation
keras-preprocessing copied to clipboard

Reference to 3rd party static blog post

Open rragundez opened this issue 6 years ago • 3 comments

In the flow_from_dataframe method there is a link in the documentation to a blog post. I don't think this is a good practice as this tutorial will clearly be deprecated with the changes. In general is not a good practice in my opinion to have 3rd party documentation that needs to continuously updated manually. Even the current blog post there points to another blog post...

https://github.com/keras-team/keras-preprocessing/blob/master/keras_preprocessing/image/image_data_generator.py#L564

rragundez avatar Mar 14 '19 13:03 rragundez

Could we have a notebook/example script in a new folder that showcase this method?

Dref360 avatar Mar 14 '19 13:03 Dref360

I think that is a great idea, something like this right? https://github.com/keras-team/keras/tree/master/examples I think we discussed it before.

rragundez avatar Mar 14 '19 13:03 rragundez

I prefer the notebook example too, feel free to remove the link any time. I made that blog post only to show the API to the world and make people start using it straight away. I personally think keras-preprocessing needs an example folder with notebooks for each API and for each problem(regression,multi-label,multi-output....).

Vijayabhaskar96 avatar Mar 18 '19 12:03 Vijayabhaskar96