keras-nlp icon indicating copy to clipboard operation
keras-nlp copied to clipboard

Run build if formatting succeeds

Open sampathweb opened this issue 2 years ago • 5 comments

sampathweb avatar Mar 10 '23 18:03 sampathweb

One additional comment - to abandon previous commit tests when a new commit is pushed, we can do something like this: https://github.com/TeamAmaze/AmazeFileManager/blob/release/3.7/.github/workflows/android-feature.yml#L10-L12

abheesht17 avatar Mar 10 '23 19:03 abheesht17

One additional comment - to abandon previous commit tests when a new commit is pushed, we can do something like this: https://github.com/TeamAmaze/AmazeFileManager/blob/release/3.7/.github/workflows/android-feature.yml#L10-L12

Nice! I am down to try this out.

Note that we have a few trigger conditions, and we do probably want to make sure we run CI for every master branch commit. But given that we squash PRs, only running on the latest commit seems like a good move!

mattdangerw avatar Mar 10 '23 21:03 mattdangerw

One additional comment - to abandon previous commit tests when a new commit is pushed, we can do something like this: https://github.com/TeamAmaze/AmazeFileManager/blob/release/3.7/.github/workflows/android-feature.yml#L10-L12

Added to actions.yml

sampathweb avatar Mar 10 '23 21:03 sampathweb

Looks like this still needs some of the changes discussed above, but ping whenever this is ready for review!

mattdangerw avatar Mar 22 '23 22:03 mattdangerw

@sampathweb, Is this PR still relevant? Are you planning to work on this.

sachinprasadhs avatar May 07 '25 20:05 sachinprasadhs

This PR is stale because it has been open for 28 days with no activity. It will be closed in 28 days if no further activity occurs. Thank you.

github-actions[bot] avatar Nov 13 '25 02:11 github-actions[bot]