Add type annotations to the bert example

Open mattdangerw opened this issue 3 years ago • 5 comments

We would like to use type annotations in KerasNLP. We should add them to the BERT example code in https://github.com/keras-team/keras-nlp/tree/master/examples/bert

Feb 08 '22 23:02 mattdangerw

I am familiar with TensorFlow/Keras and the BERT theory and implementations (from the TensorFlow Model Garden). I would like to take this task and will send a PR later.

Feb 13 '22 08:02 howl-anderson

Thank you! Please tag me for review!

Feb 24 '22 04:02 mattdangerw

Hey Is this issue still open?

Mar 20 '22 08:03 aflah02

Hi @aflah02, sorry for the slow progress. I am still working on adding type annotations to the BERT.

Mar 20 '22 11:03 howl-anderson

Hey @howl-anderson That's cool, no need to say sorry I was just looking around :) and must've missed that you're already assigned

Mar 20 '22 11:03 aflah02

Keras as a whole is not pursuing type annotations at the moment.

Oct 18 '23 20:10 mattdangerw