keras-nlp icon indicating copy to clipboard operation
keras-nlp copied to clipboard

Port Data Parallel Training example to multi-backend

Open shivance opened this issue 11 months ago • 14 comments

Link : https://github.com/keras-team/keras-io/blob/master/examples/nlp/data_parallel_training_with_keras_nlp.py

The tutorial was originally written in Keras, we need to port this to Keras Core with multi backend support.

shivance avatar Jul 26 '23 05:07 shivance

Can I work on this issue?

rajchordia14 avatar Jul 26 '23 06:07 rajchordia14

Sure @rajchordia14 ! You are welcome to contribute. Please open a PR at keras-team/keras-io ! We can use this thread to discuss if you need any help!

shivance avatar Jul 26 '23 06:07 shivance

Hi @rajchordia14 any update? are you stuck somewhere and need help?

shivance avatar Aug 14 '23 04:08 shivance

Working on it, first ever contribution might take time. Apologies for delay

rajchordia14 avatar Aug 14 '23 09:08 rajchordia14

@rajchordia14 are you still working on this or can I take over and start working on it

pranavvp16 avatar Aug 20 '23 14:08 pranavvp16

@pranavvp16 you may start working on this if you still are interested. Please try to come up with a colab. Then we could iterate on it.

shivance avatar Sep 01 '23 09:09 shivance

fine I'll start working today

pranavvp16 avatar Sep 01 '23 09:09 pranavvp16

@shivance I changed the imports according to the new keras-core and ran the example, the example ran fine with pytroch as backend but when backend is set to tensorflow there's an error. Below is the link to collab notebook pytorch as backend tensorflow as backend Seems there is something missing in optimizers file in tensorflow backend

pranavvp16 avatar Sep 01 '23 15:09 pranavvp16

This is strange, can you open a seperate issue to file this bug?

shivance avatar Sep 01 '23 15:09 shivance

I should be opening the issue in keras-core repository right ?

pranavvp16 avatar Sep 01 '23 15:09 pranavvp16

keras-nlp for now

shivance avatar Sep 01 '23 15:09 shivance

@shivance can I make the PR for converted code sample as it works with other backends, and once the above issue is fixed it will work with tensroflow too

pranavvp16 avatar Sep 03 '23 04:09 pranavvp16

Yes, please go ahead! Please open seperate issues for each bug you face. Keras team tracks all the work through github issues.

shivance avatar Sep 06 '23 05:09 shivance

This issue is stale because it has been open for 180 days with no activity. It will be closed if no further activity occurs. Thank you.

github-actions[bot] avatar Mar 12 '24 01:03 github-actions[bot]