keras-nlp Add ragged support to SinePositionEncoding

Add ragged support to SinePositionEncoding

Open mattdangerw opened this issue 3 years ago • 2 comments

We should add support for ragged inputs to the SinePositionEncoding layer.

Our PositionEmbedding layer shows a rough example of how this can be done on this line

Apr 12 '22 02:04 mattdangerw

@mattdangerw, I'd like to take this up. Thanks!

Apr 12 '22 03:04 abheesht17

Sure thing! Though for small issues like these, try to leave some of these available for newcomers to the project as well. Thanks!

Apr 12 '22 23:04 mattdangerw

I am interested.

Feb 11 '23 07:02 Neeshamraghav012

Hi @mattdangerw, I can see a merged PR. Is this still open? If not, I would like to work on this.

Mar 02 '23 15:03 jaygala223

Ah, this is indeed fixed! Thanks.

Mar 02 '23 23:03 mattdangerw