keras-cv icon indicating copy to clipboard operation
keras-cv copied to clipboard

Add Convolution Block Attention

Open GLOMQuyet opened this issue 2 years ago • 1 comments

What does this PR do?

Fixes # (issue)

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
  • [ ] Did you write any new necessary tests?
  • [ ] If this adds a new model, can you run a few training steps on TPU in Colab to ensure that no XLA incompatible OP are used?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

GLOMQuyet avatar Oct 15 '22 15:10 GLOMQuyet

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 15 '22 15:10 google-cla[bot]

ticket https://github.com/keras-team/keras-cv/issues/324

innat avatar Oct 15 '22 17:10 innat

even though it's a match, I haven't seen #324 yet. I will consider making more suggestions

GLOMQuyet avatar Oct 16 '22 07:10 GLOMQuyet

Thanks for your enthusiasm @GLOMQuyet !

Apologies for shifting priorities and changes in terms of what we are interested in merging. We've done a lot of work to figure out exactly what our value add to users is, what components we want to offer as APIs, and we don't want to offer as APIs in the last few years. For now, I think closing this PR makes sense and if models need this component we can implement this style layer alongside the model.

This usually has to happen to match exact numerics of architectures anyways. For now lets close, and if theres a super strong user need to fill we can re-open.

LukeWood avatar Apr 26 '23 22:04 LukeWood