keras-cv icon indicating copy to clipboard operation
keras-cv copied to clipboard

Attaching Resarch Paper for Pascal_voc and imagenet dataset are not attahced in the load.py

Open NiharJani2002 opened this issue 2 years ago • 5 comments

Short Description Attaching the Research Paper link and website link of the Pascal_voc and Imagenet dataset.

The Research Paper of Waymo Dataset has been merged through this pull request https://github.com/keras-team/keras-cv/pull/1975

Research Paper And Website Links

  1. For Pascal_Voc Dataset: Research Paper: http://host.robots.ox.ac.uk/pascal/VOC/pubs/everingham15.pdf Website: http://host.robots.ox.ac.uk/pascal/VOC/

2)Imagenet Dataset: Research Paper: https://ieeexplore.ieee.org/document/5206848 Website: https://www.image-net.org/

Existing Implementations https://github.com/keras-team/keras-cv/pull/1975

Reviewers @ianstenbit @jbischof

Hey, reviewers assign me the issue, so I can generate a pull request for solving the purpose of this issue. I have also attached some links of the research paper and website, pls give some feedback if some better links are available on behalf of that.

NiharJani2002 avatar Jul 26 '23 17:07 NiharJani2002

Guidance needed.

I attached the research paper and website link of ImageNet Dataset in the load docs.py, but while checking at various Python lint checking websites such as:

  1. https://infoheap.com/python-lint-online/
  2. https://extendsclass.com/python-tester.html

I found out that there is a lint error in the code, but the main imp thing is that the lint error is not because of the research paper and website link, but because of this line, """ if batch_size is not None and img_size is None: raise ValueError( "Batching can only be performed if images are resized." ) """ I am also attaching image for the above context: load py lint error

Should I generate a pull request for the attached research paper and website link it, or how to solve this? @ianstenbit @jbischof

NiharJani2002 avatar Jul 27 '23 08:07 NiharJani2002

Guidance needed.

I attached the research paper and website link of ImageNet Dataset in the load docs.py, but while checking at various Python lint checking websites such as:

  1. https://infoheap.com/python-lint-online/
  2. https://extendsclass.com/python-tester.html

I found out that there is a lint error in the code, but the main imp thing is that the lint error is not because of the research paper and website link, but because of this line, """ if batch_size is not None and img_size is None: raise ValueError( "Batching can only be performed if images are resized." ) """ I am also attaching image for the above context: load py lint error

Should I generate a pull request for the attached research paper and website link it, or how to solve this? @ianstenbit @jbischof

we use our own linter that you can run from the base directory of the package with sh shell/lint.sh. Any lint issues from outside tools are not a concern for our linting.

ianstenbit avatar Jul 27 '23 18:07 ianstenbit

I get the lint error from the, Keras-CV, I am also attaching image of it,

image

If We look at The Code if load.py of ImagNet Dataset, the line is also referencing to above code, which is ""

if batch_size is not None and img_size is None: raise ValueError( "Batching can only be performed if images are resized." )

"""

Attaching an image of the code,

image

So, More Understanding of the problem, I used other tools.

How Do I Solve this issue? Should I generate a issue of this also, or should I create a pull request for the attached research paper and website, leaving this issue for the future?

@ianstenbit @jbischof

NiharJani2002 avatar Jul 28 '23 16:07 NiharJani2002

If you just open a PR with your new research paper reference we can look at the linter error in the PR

ianstenbit avatar Jul 31 '23 12:07 ianstenbit

A New Pull Request Is Generated, ImageNet Research Paper And Website Added In The load.py #1999

@ianstenbit @jbischof

Waiting for suggestions for modifications of PR

NiharJani2002 avatar Aug 01 '23 14:08 NiharJani2002