keras-cv icon indicating copy to clipboard operation
keras-cv copied to clipboard

Published 20 hours ago • verified publisher icon keras-team

Vectorize CropAndResize

Open soma2000-lang opened this issue 2 years ago • 17 comments

#1415 cc @LukeWood @ianstenbit

Results

soma2000-lang avatar Feb 23 '23 06:02 soma2000-lang

@soma2000-lang looks like the unit tests are failing!

LukeWood avatar Feb 24 '23 18:02 LukeWood

@LukeWood looking into this.Actually keras-cv is not properly installed in my system because after some system update the pip package did not seem to work.I am trying to fix the problem with pip right now.

soma2000-lang avatar Feb 24 '23 18:02 soma2000-lang

@LukeWood I am trying to fix the pip issue with my system.Till I fix this,

I just run the test using Google Colab and it seems to pass.

Link -https://colab.research.google.com/drive/1-TZpbQDMp1fe3mrfvouWAqH_PISf9SBh?usp=sharing

it will be great if you check it once.

soma2000-lang avatar Feb 25 '23 04:02 soma2000-lang

Screen Shot 2023-02-25 at 1 46 13 PM

LukeWood avatar Feb 25 '23 21:02 LukeWood

@soma2000-lang left a comment including a merge conflict. Can you resolve?

LukeWood avatar Feb 25 '23 21:02 LukeWood

@LukeWood Resolved

soma2000-lang avatar Feb 25 '23 22:02 soma2000-lang

@soma2000-lang the goal is to independently augment each image. I think getting this to work will require you to update the logic a bit.

LukeWood avatar Mar 06 '23 22:03 LukeWood

@LukeWood I made required changes.But some tests are still failing!

soma2000-lang avatar Mar 07 '23 00:03 soma2000-lang

It looks like this is a legitimate failure - can you fix the test failures? @soma2000-lang

LukeWood avatar Mar 07 '23 20:03 LukeWood

@LukeWood I sent you an email 2 days back .The emIl id starts with seckroll16 .I would be really greatfull if you can check out once.😊

Regards

soma2000-lang avatar Mar 08 '23 04:03 soma2000-lang

@james77777778 It would be great if youvcan help me with this.I am stuck on this for long.

soma2000-lang avatar Mar 12 '23 02:03 soma2000-lang

Hi @soma2000-lang I have roughly read your PR and I can share the idea about self.get_random_transformation_batch

https://colab.research.google.com/drive/15ed5Fqn5zrQClmmuvB1DWrDGwMrHA4Ka?usp=sharing

I think the vectorizing could be complete by modifying self._transform_bounding_boxes and self._crop_and_resize based on batched and independently sampled transformations

james77777778 avatar Mar 13 '23 02:03 james77777778

@james77777778 Thanks!

soma2000-lang avatar Mar 13 '23 02:03 soma2000-lang

@soma2000-lang can you add a test like the one in https://github.com/keras-team/keras-cv/pull/1480/files#diff-1c771135874332a25b437da4a5706faea85ff719331dfe7beb255403a1a66477

LukeWood avatar Mar 14 '23 18:03 LukeWood

@LukeWood sure!.Also sorry for the delay I will try to finish this pr soon.

soma2000-lang avatar Mar 14 '23 18:03 soma2000-lang

@soma2000-lang can you please rebase with master?

divyashreepathihalli avatar Dec 07 '23 23:12 divyashreepathihalli

Sure

soma2000-lang avatar Dec 08 '23 01:12 soma2000-lang