NoCoin icon indicating copy to clipboard operation
NoCoin copied to clipboard

"White list for 1 min" in some cases is not work

Open KinoLien opened this issue 7 years ago • 4 comments

Reproduce steps:

  1. Goto https://coin-hive.com/ website.
  2. Click "White list for 1 min" in "No Coin" popup.
  3. Click "Start Mining" on homepage.
  4. 1 min later, mining still working.

I don't know it is bug or not?

Ps. My userAgent: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.101 Safari/537.36"

KinoLien avatar Sep 20 '17 05:09 KinoLien

Thanks for the bug report, I will see if I can find a Mac to repro this. In the meantime, could you right click on the extension and inspect the pop-up while on coin-hive.com? Are there any errors in the console?

keraf avatar Sep 20 '17 08:09 keraf

Nope, nothing appears on console.

The coin-hive will create few Workers in background for mining, and i want to know that do we have the close Workers permission in content/background scripts of chrome extension? (I tried to find out, but not found yet.)

so If not, may be force refresh main page when 1 or 30 min(s) later.

how's this idea?

KinoLien avatar Sep 20 '17 10:09 KinoLien

Oh sorry, I misunderstood the original request.

This is a bit of an edge case. The risk of reloading a page once the whitelist is expired is that a user would have content in progress that he would loose if the page would be refreshed. By navigating away the blocking would kick in anyway. I guess an enhancement would be to notify the user that website is not white listed any more but I guess that's very low priority.

keraf avatar Sep 20 '17 21:09 keraf

You could add an option where the user could select if it turns off the mining, notifies the user, or neither.

Alternatively, and this is a more complex solution, you could have it wait until it finished the jobs currently in progress and then stops.

Leondthurrell avatar Sep 21 '17 08:09 Leondthurrell