messenger
messenger copied to clipboard
Subdomains considered invalid URLs
I'd fix this myself and submit a pull request but I'm not very handy with regex and wouldn't want to muck things up...
I'm running into situations where urls with subdomains are coming back as invalid URLs from the isValidUrl method linked below - is this intended?
https://github.com/ker0x/messenger/blob/6bc832af94fb48b8f2edefb11b85f6bf47d7c09e/src/Helper/ValidatorTrait.php#L49
Hello @mferrara,
Can you provide an example of a sub-domain that does not pass validation?
Gladly! - https://jjlynboutique.espwebsite.com
Well, it's weird, all the tests I did with your url are validated. By calling which method the validation fails?
It's thrown when calling this method...
$buttons[] = WebUrl::create($button_text, $button_action);