lifecycle-toolkit icon indicating copy to clipboard operation
lifecycle-toolkit copied to clipboard

feat(metrics-operator): introduce insecureSkipTlsVerify parameter for prometheus metrics fetch

Open Bharadwajshivam28 opened this issue 1 year ago • 6 comments

fixes #3712

Hey @odubajDT @mowies I have implemented TLS round tripper to handle HTTP request.

Bharadwajshivam28 avatar Oct 05 '24 00:10 Bharadwajshivam28

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 77.73%. Comparing base (ffc01b6) to head (aa679a0). :warning: Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3742      +/-   ##
==========================================
- Coverage   77.77%   77.73%   -0.04%     
==========================================
  Files         219      219              
  Lines       11575    11580       +5     
==========================================
  Hits         9002     9002              
- Misses       2210     2214       +4     
- Partials      363      364       +1     
Files with missing lines Coverage Δ
.../controllers/common/providers/prometheus/common.go 90.00% <100.00%> (+2.00%) :arrow_up:

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 47.44% <ø> (ø)
component-tests 79.40% <ø> (-0.32%) :arrow_down:
lifecycle-operator 79.68% <ø> (ø)
metrics-operator 75.95% <100.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 07 '24 06:10 codecov[bot]

Hey @odubajDT I have modified the GetRoundTripper function to use a custom http.Transport with TLSClientConfig.

Bharadwajshivam28 avatar Oct 09 '24 11:10 Bharadwajshivam28

@Bharadwajshivam28 any updates on this?

mowies avatar Nov 11 '24 07:11 mowies

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 09 '25 03:02 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 11 '25 03:04 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 11 '25 03:06 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 11 '25 03:08 github-actions[bot]