feat(metrics-operator): introduce insecureSkipTlsVerify parameter for prometheus metrics fetch
fixes #3712
Hey @odubajDT @mowies I have implemented TLS round tripper to handle HTTP request.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 77.73%. Comparing base (ffc01b6) to head (aa679a0).
:warning: Report is 14 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3742 +/- ##
==========================================
- Coverage 77.77% 77.73% -0.04%
==========================================
Files 219 219
Lines 11575 11580 +5
==========================================
Hits 9002 9002
- Misses 2210 2214 +4
- Partials 363 364 +1
| Files with missing lines | Coverage Δ | |
|---|---|---|
| .../controllers/common/providers/prometheus/common.go | 90.00% <100.00%> (+2.00%) |
:arrow_up: |
... and 1 file with indirect coverage changes
| Flag | Coverage Δ | |
|---|---|---|
| certificate-operator | 47.44% <ø> (ø) |
|
| component-tests | 79.40% <ø> (-0.32%) |
:arrow_down: |
| lifecycle-operator | 79.68% <ø> (ø) |
|
| metrics-operator | 75.95% <100.00%> (+0.03%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Hey @odubajDT I have modified the GetRoundTripper function to use a custom http.Transport with TLSClientConfig.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
@Bharadwajshivam28 any updates on this?
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.