lifecycle-toolkit icon indicating copy to clipboard operation
lifecycle-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon keptn

Introduce tests for lifecycle-operator bugs

Open odubajDT opened this issue 11 months ago • 11 comments

Recently multiple small bugs were found and fixed as part of this PR.

The places are:

  • https://github.com/keptn/lifecycle-toolkit/pull/3113/files#diff-7e3a3dd6a5940394c614f51b5abf528919d2593178aad9cfbbe963bdc261dc6bR212
  • https://github.com/keptn/lifecycle-toolkit/pull/3113/files#diff-7e3a3dd6a5940394c614f51b5abf528919d2593178aad9cfbbe963bdc261dc6bR238
  • https://github.com/keptn/lifecycle-toolkit/pull/3113/files#diff-9a3cc86b3f6c7660bf48ab0906ad69cc9500e27fc6b648f0d577f92f0078933dR162

Introduce unit tests to cover the affected functionality

odubajDT avatar Feb 26 '24 07:02 odubajDT

Hi @odubajDT , I can try to solve this issue. Can you assign it to me?

Thank you!

SohamRatnaparkhi avatar Feb 27 '24 04:02 SohamRatnaparkhi

Hi @SohamRatnaparkhi are you actively working on this issue? Since you have this issue assigned for aprox. 10 days, we usually unassign asignees from their issues if there is no activity to not block other potential contributors from starting to tackle them.

Thanks for the update!

odubajDT avatar Mar 08 '24 08:03 odubajDT

Hey @odubajDT Really sorry for holding on to the issue. I'm busy right now and can't solve it. Feel free to assign it to someone else.

Once again, I'm really sorry :)

SohamRatnaparkhi avatar Mar 08 '24 09:03 SohamRatnaparkhi

No worries, thank you very much for your answer! :) If you have time in the future, we would be happy if you reach out to us for potentially another issue!

odubajDT avatar Mar 08 '24 09:03 odubajDT

Hey I can take on this one If no one is working

Bharadwajshivam28 avatar Mar 14 '24 12:03 Bharadwajshivam28

Hi @Bharadwajshivam28 are you actively working on this issue? Since you have this issue assigned for aprox. 3 weeks, we usually unassign asignees from their issues if there is no activity to not block other potential contributors from starting to tackle them.

Thanks for the update!

odubajDT avatar Apr 02 '24 13:04 odubajDT

Due to inactivity, unassigning @Bharadwajshivam28 from this issue. Feel free to request a different issue!

odubajDT avatar Apr 03 '24 06:04 odubajDT

Hi @odubajDT I would like to work on the above issue

YashPimple avatar Apr 05 '24 13:04 YashPimple

@YashPimple I assigned it to you but please before you start, there is a small change required in the PR you have opened https://github.com/keptn/lifecycle-toolkit/pull/3143. try to please finish this one first before you start with a new one

odubajDT avatar Apr 09 '24 08:04 odubajDT

Hi! @odubajDT, I would like to take up this issue.

Since the non-blocking mode does not introduce any errors in the controller, we can write a unit test with a mock handler that does not return any errors when the KeptnAppVersionStatus resembles the manifest in the docs

Am I correctly understanding the task here?

Jay179-sudo avatar Jul 06 '24 13:07 Jay179-sudo

@Jay179-sudo sure thing, I assigned it to you

mowies avatar Jul 10 '24 08:07 mowies