keptn icon indicating copy to clipboard operation
keptn copied to clipboard
verified publisher icon keptn

feat(installer): Refactoring labels and additional labels support

Open nlamirault opened this issue 3 years ago • 4 comments

This PR

  • Refactoring Kubernetes labels
  • Support for additional labels to set into all resources

Related Issues

Fixes

Notes

Follow-up Tasks

How to test

nlamirault avatar Apr 22 '22 14:04 nlamirault

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 22 '22 14:04 sonarqubecloud[bot]

hi @nlamirault! first of all, thanks for the contribution!

I am actually already working on a refactoring PR for the helm charts which also includes parts of your changes here(the labels refactoring, not the additional labels). I think a good plan would be to wait for my refactoring to be done and then merge the 2 PRs together. what do you think?

mowies avatar Apr 25 '22 06:04 mowies

Sure @mowies

nlamirault avatar Apr 25 '22 07:04 nlamirault

Hi @nlamirault (sorry for the long wait, I lost track of this) All the refactoring is done. A lot has changed as you can see by the conflicts in this PR, sorry...

mowies avatar Sep 21 '22 05:09 mowies

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 07 '23 19:01 stale[bot]