typescript-sdk icon indicating copy to clipboard operation
typescript-sdk copied to clipboard

Published 20 hours ago • verified publisher icon keploy

Fix sdk records test case in record mode

Open frey0-0 opened this issue 1 year ago • 6 comments

Fixes: #430 TS-SDK was saving tests in test mode also which shouldn't be the case, it should only save tests in the record mode. I have figured out the correct location to apply the correct if condition.

frey0-0 avatar Mar 10 '23 01:03 frey0-0

@re-Tick Can you please review this? @Frey0-0 Please wait while the maintainers review this. After that you can add this in the completed task list in the gsoc repo!

developer-diganta avatar Mar 10 '23 14:03 developer-diganta

Sure @developer-diganta, can you point me to some other issues in the meantime? Would be really kind of you 🚀

frey0-0 avatar Mar 10 '23 16:03 frey0-0

Are there any more changes required on this PR or should I add this in the completed tasks list? @re-Tick

frey0-0 avatar Mar 12 '23 17:03 frey0-0

@Frey0-0 please add link to this PR in GSOC/2023 ts-sdk task list corresponding to its issue.

re-Tick avatar Mar 12 '23 17:03 re-Tick

Done!

frey0-0 avatar Mar 12 '23 23:03 frey0-0

Sure @developer-diganta, can you point me to some other issues in the meantime? Would be really kind of you 🚀

Hey @Frey0-0 ! Congrats on completing this PR! Also, you can try out the other tasks in the task list for typescript sdk or any other project that you would want to contribute to!

developer-diganta avatar Mar 13 '23 05:03 developer-diganta