typescript-sdk icon indicating copy to clipboard operation
typescript-sdk copied to clipboard
verified publisher icon keploy

Adding Unit test cases for wrappedNodeFetch and adding github actions

Open Hermione2408 opened this issue 2 years ago • 10 comments

For code coverage added unit test for wrappedNodeFetch function and integrated git hub actions.

test #354 Closes: https://github.com/keploy/keploy/issues/354

Hermione2408 avatar Mar 08 '23 17:03 Hermione2408

Hi @re-Tick! Can you please review the PR?

developer-diganta avatar Mar 08 '23 17:03 developer-diganta

@Hermione2408 please resolve DCO and commitzen

re-Tick avatar Mar 08 '23 19:03 re-Tick

Can you have a look now @re-Tick

Hermione2408 avatar Mar 08 '23 20:03 Hermione2408

Hey @re-Tick , Can you please review the changes now

Hermione2408 avatar Mar 13 '23 15:03 Hermione2408

a test is failing. I will try these changes locally and request changes if any.

re-Tick avatar Mar 14 '23 06:03 re-Tick

Sure I'll try to resolve too where they are failing

Hermione2408 avatar Mar 14 '23 08:03 Hermione2408

@re-Tick I have made the changes and it is passing all the test cases now.

Hermione2408 avatar Mar 14 '23 10:03 Hermione2408

LGTM. Please add this PR link in GSOC task list.

re-Tick avatar Mar 15 '23 07:03 re-Tick