keploy icon indicating copy to clipboard operation
keploy copied to clipboard

ci: added pipeline to test colima support on macos

Open nakul-krishnakumar opened this issue 1 month ago • 19 comments

Describe the changes that are made

  • Wrote a pipeline to test colima support.

Links & References

Closes: #3119

🔗 Related PRs

  • NA

🐞 Related Issues

  • #3119

📄 Related Documents

  • NA

What type of PR is this? (check all applicable)

  • [ ] 📦 Chore
  • [ ] 🍕 Feature
  • [ ] 🐞 Bug Fix
  • [ ] 📝 Documentation Update
  • [ ] 🎨 Style
  • [ ] 🧑‍💻 Code Refactor
  • [ ] 🔥 Performance Improvements
  • [ ] ✅ Test
  • [x] 🔁 CI
  • [ ] ⏩ Revert

Added e2e test pipeline?

  • [ ] 👍 yes
  • [x] 🙅 no, because they aren't needed
  • [ ] 🙋 no, because I need help

Added comments for hard-to-understand areas?

  • [x] 👍 yes
  • [ ] 🙅 no, because the code is self-explanatory

Added to documentation?

  • [ ] 📜 README.md
  • [ ] 📓 Wiki
  • [x] 🙅 no documentation needed

Are there any sample code or steps to test the changes?

  • [ ] 👍 yes, mentioned below
  • [x] 🙅 no, because it is not needed

Self Review done?

  • [] ✅ yes
  • [x] ❌ no, because I need help

Any relevant screenshots, recordings or logs?

  • NA

🧠 Semantics for PR Title & Branch Name

Please ensure your PR title and branch name follow the Keploy semantics:

📌 PR Semantics Guide
📌 Branch Semantics Guide

Examples:

  • PR Title: fix: patch MongoDB document update bug
  • Branch Name: feat/#1-login-flow (You may skip mentioning the issue number in the branch name if the change is small and the PR description clearly explains it.)

Additional checklist:

nakul-krishnakumar avatar Oct 30 '25 06:10 nakul-krishnakumar

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Oct 30 '25 06:10 github-actions[bot]

The CLA check failed. Please ensure you have:

  • Signed the CLA by commenting 'I have read the CLA Document and I hereby sign the CLA.'
  • Used the correct email address in your commits (matches the one you used to sign the CLA).

After fixing these issues, comment 'recheck' to trigger the workflow again.

github-actions[bot] avatar Oct 30 '25 06:10 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

nakul-krishnakumar avatar Oct 30 '25 06:10 nakul-krishnakumar

recheck

nakul-krishnakumar avatar Oct 30 '25 06:10 nakul-krishnakumar

hey how have you tested this?

could you test this on your fork and give me the url of the action run?

officialasishkumar avatar Oct 30 '25 08:10 officialasishkumar

Hey @officialasishkumar , I wasn't sure on how to test the action. Thank you for the suggestion, I will do it asap and give you the url. Also there have been few errors which I am now fixing, so should I close this PR and do a new one with the corrected script or is it fine if I do multiple fixing commits in this same PR? Thank you for the help! :)

nakul-krishnakumar avatar Oct 30 '25 09:10 nakul-krishnakumar

You can do everything in this PR

officialasishkumar avatar Oct 30 '25 09:10 officialasishkumar

@officialasishkumar Hey, I have been trying to fix the pipeline for the past couple of hours, but have been getting errors. This is the action url: https://github.com/nakul-krishnakumar/keploy/actions/runs/18944275108/job/54091070714?pr=1 Could you please verify it and let me know what changes can be made it resolve the error? Also the entire pipeline is taking more than 20 minutes to run. Is that expected or is my entire approach wrong? Please let me know that so I can fix accordingly. Thank you :)

nakul-krishnakumar avatar Oct 30 '25 14:10 nakul-krishnakumar

Successfully tested the pipeline here: https://github.com/nakul-krishnakumar/keploy/actions/runs/18965288414/job/54160611528?pr=1, and it finally works as expected. Please review it @officialasishkumar .

nakul-krishnakumar avatar Oct 31 '25 07:10 nakul-krishnakumar

will review

officialasishkumar avatar Oct 31 '25 07:10 officialasishkumar

Hey @officialasishkumar, I was trying to fix the DCO error and other commits got into this PR. Now this PR says updates 13 files. Please review and let me know what I should do. Should I create a new PR?

nakul-krishnakumar avatar Oct 31 '25 15:10 nakul-krishnakumar

Tested the updated workflow with code written in .sh file, it works perfectly, Link: https://github.com/nakul-krishnakumar/keploy/actions/runs/18979485830/job/54208064640?pr=1 Please let me know if I should make a separate PR as in the current PR I can see some other commits that came when I did force push to resolve DCO error. @officialasishkumar

nakul-krishnakumar avatar Oct 31 '25 17:10 nakul-krishnakumar

i have updated the branch

officialasishkumar avatar Nov 02 '25 11:11 officialasishkumar

i have updated the branch

Thanks, and btw when you asked me to move all code to .sh, did you also mean docker cli commands?

nakul-krishnakumar avatar Nov 02 '25 11:11 nakul-krishnakumar

Updated the code to follow project convention. New workflow ran successfully: github.com/nakul-krishnakumar/keploy/actions/runs/19012134057/job/54294646438?pr=1 @officialasishkumar

nakul-krishnakumar avatar Nov 02 '25 12:11 nakul-krishnakumar

Will look into it

officialasishkumar avatar Nov 02 '25 12:11 officialasishkumar

@officialasishkumar updated the workflow to use samples/gin-mingo . :+1:

nakul-krishnakumar avatar Nov 03 '25 10:11 nakul-krishnakumar

@officialasishkumar any updates?

nakul-krishnakumar avatar Nov 08 '25 13:11 nakul-krishnakumar

@officialasishkumar any updates on this PR?

nakul-krishnakumar avatar Nov 27 '25 09:11 nakul-krishnakumar