opus icon indicating copy to clipboard operation
opus copied to clipboard

stopgap fix for opus icons on newer MC

Open Merith-TK opened this issue 2 years ago • 5 comments

Opus Utils.getVersion results in returning 1.1 rather than anything newer when on the 1.100.x CC versions (fabric and forge)

this is an stop gap fix, and yes, If I knew how I would tweak the matchers to make it work, but I dont so this will do, because whoever is on CC 1.1... needs to get off it,

Merith-TK avatar Jul 04 '22 13:07 Merith-TK

I think this might break again when CC:T 1.110.0 is released, here are some other ideas I had:

  • Multiply the minor version by 10 if it is >= 100 (so for example, CC:T 1.100 would become 2.0, and 1.105 would become 2.05)
  • Just use the CC minor version (so, for example, CC:T 1.88 would become 88, and 1.105 would become 105)
  • The above but only if the CC minor version is above 85 or something (for example, CC:T 1.84 would still be 1.84, while 1.86 would be 86) Here are all the usages of Util.getVersion(): https://github.com/kepler155c/opus/search?q=getVersion https://github.com/kepler155c/opus-apps/search?q=getVersion

Kan18 avatar Jul 04 '22 13:07 Kan18

well, as the commit says, and the file comments I put in, this is an stopgap, not pretty, and definitely could use improvement, but it gets the job done without being too invasive on the code

Merith-TK avatar Jul 04 '22 14:07 Merith-TK

so... any ideas for an better implementation of an fix?

Merith-TK avatar Jul 15 '22 21:07 Merith-TK

I think Anavrins mentioned at one point that returning multiple values could be a good implementation. I can try working on that (this is somewhat urgent now, since SwitchCraft 2 is literally going away in 12 minutes, and the new version will be on SC3 so more people will run into this bug; if anybody who isn't currently online is seeing this comment right now, please join!)

Kan18 avatar Dec 27 '22 17:12 Kan18

With the release of SC3 this fix would be very much needed so icons can actually render

Merith-TK avatar Jan 01 '23 17:01 Merith-TK