chromeEyeDropper icon indicating copy to clipboard operation
chromeEyeDropper copied to clipboard

Not Working on Long Pages

Open handsfreemc opened this issue 9 years ago • 4 comments

Pick a color from web page stalls out

I've refreshed, closed browser, and reinstalled the extension. Still, the circling ball will not stop spinning, so the cursor can never select a color. It usually takes about a second. For now, it's spinning several minutes with no stabilization.

handsfreemc avatar Aug 03 '16 04:08 handsfreemc

Just noticed it's an isolated problem happening on this page: [https://designschool.canva.com/blog/100-color-combinations/] Tested on yahoo.com main and it's working properly.

handsfreemc avatar Aug 03 '16 04:08 handsfreemc

Thanks for report, I can reproduce it. I'm marking it as low because it is only problem on specific page. Anyway I should get to it soon after new version release (which is almost finished).

kepi avatar Aug 03 '16 20:08 kepi

Ok, this problem is more serious than I thought. Eye Dropper is not working correctly on larger pages (longer than 32747 pixels). Its big change to fix this properly. I need to rewrite most of color picking logic.

Anyway, I made quick hack now which fix this at least partially. You can use Eye Dropper now on long pages but it will work only at start of a page (before you scroll more than those 32k pixels). I think is sufficient for most use cases. Of course, I'll fix this properly, but it will take some time.

kepi avatar Aug 14 '16 19:08 kepi

@kepi Great to know, thanks for the update.

handsfreemc avatar Aug 20 '16 23:08 handsfreemc