obsidian-minimal-settings icon indicating copy to clipboard operation
obsidian-minimal-settings copied to clipboard

Fix broken --font-editor-override default value

Open jhanschoo opened this issue 1 year ago • 3 comments

The default value (empty string) for --font-editor-override interferes with the way the base Minimal plugin defines the --font-editor variable (https://github.com/kepano/obsidian-minimal/blob/8cb709a373c9601a9e9172eaa75fdbeba4412c43/src/scss/variables/root.scss#L3) causing it to hold an invalid value (e.g. see embedded image), and interferes with themeing specified otherwise.

image

This PR 1) fixes it to use the strategy in base Obsidian to use a dummy '??' font (notice it being set on --font-text-override from the core Appearance settings by default), and 2) changes the settings item to be more in line with how other settings are presented as well.

Note of course that there is a lack of validation in these values and that changing most other settings here to empty or invalid values breaks stuff, but this seems to be the only one with a problematic default value and adding in validation is out of scope for this tiny PR.

jhanschoo avatar Sep 28 '24 06:09 jhanschoo

bump @kepano

jhanschoo avatar Nov 12 '24 02:11 jhanschoo

bump @kepano

jhanschoo avatar Jan 07 '25 04:01 jhanschoo

bump @kepano

jhanschoo avatar Apr 04 '25 14:04 jhanschoo