algorithms icon indicating copy to clipboard operation
algorithms copied to clipboard

Published 20 hours ago • verified publisher icon keon

Naming conventions

Open memeplex opened this issue 7 years ago • 5 comments

Not that this is all too important, but given that in a (lesser) sense yours is also a python programming showcase, wouldn't it be desirable to honour pep8 suggestions? For example, to avoid camel case names like isEmpty.

memeplex avatar Apr 23 '17 00:04 memeplex

Yeah, PEP8 is good and I think it is important. The current implementation has mixed styles, which I think is confusing. I just didn't have time to organize them. I think I'll do so in a month.

keon avatar Apr 23 '17 00:04 keon

Hi, I'd like to take this up.

parth-verma avatar Apr 07 '18 15:04 parth-verma

#242

muneeb20 avatar Apr 21 '18 08:04 muneeb20

Since this issue is still open, I'd like to take this up and make another PEP8 style review. (also noting #242)

feygon avatar Aug 15 '18 07:08 feygon

Have the issues been solved with the two merged PR?

ruijpbastos avatar Aug 20 '21 09:08 ruijpbastos