react-electron-webview icon indicating copy to clipboard operation
react-electron-webview copied to clipboard

Typescript compiler error

Open jerrGordon opened this issue 7 years ago • 2 comments

In the index.d.ts file there is a reference to the Electron webview element. tsc 2.4.2 throws this error ERROR in [at-loader] ./node_modules/react-electron-webview/index.d.ts:5:69 TS2694: Namespace 'Electron' has no exported member 'WebViewElement'. I believe the Electron element is called Electron.WebviewTag

jerrGordon avatar Aug 02 '17 11:08 jerrGordon

I'm getting runtime errors after monkey patching that issue locally. "TypeError: Cannot read property 'bool' of undefined" in node_modules/react-electron-webview/index.js

yoDon avatar Nov 12 '17 22:11 yoDon

@yoDon This appears to be due to higher versions of React no longer supporting 'React.PropTypes' - PropTypes is now its own package: https://reactjs.org/docs/typechecking-with-proptypes.html.

The notation will need to be updated in webview.js to support React 15.5+.

flowermm avatar Nov 14 '17 19:11 flowermm