godot-addons icon indicating copy to clipboard operation
godot-addons copied to clipboard

Compatibility fix for 4.3 release

Open ceejbro opened this issue 1 year ago • 2 comments

Godot 4.3 seems to have changed something about the order required now. Plugin would not load properly or at all until this reordering.

NOTE: the documentation for the method add_submenu_item is now DEPRECATED and a new method was added add_submenu_node_item

ceejbro avatar Aug 16 '24 02:08 ceejbro

Thanks for the contribution! Can you verify if the bug also exists with the 4.3 branch?

Edit: Might be fixed here https://github.com/kenyoni-software/godot-addons/commit/15ae7146d1bb59c872bd7fdc2f0963ed36686a6b

IceflowRE avatar Aug 16 '24 07:08 IceflowRE

Just checked with 4.3 branch with full setup and again with licenses addon only to verify against dependencies. Looks like you'd run into that at some point, because the reordering was present in the same spot in the toolbar.gd. Back to functioning!

Just mind the deprecated function mentioned. :)

ceejbro avatar Aug 16 '24 13:08 ceejbro