Ken Yee comments

Results 107 comments of


                                            Ken Yee

CI Unit Test Job Failing

I'd still recommend targeting the latest. Not sure why mockito is failing in CI though 🤔

Allow Injection of Logging Implementation (e.g. Add Support for SLF4J)

Breakpoints not hit on annotated methods

Ever get a chance to try -XnoInline? Source code seems to show it's not in yet...

Spurious build warnings on "com.facebook.infer.annotation.Nullsafe$Mode not found"

@yuxia761 did that work?

Spurious build warnings on "com.facebook.infer.annotation.Nullsafe$Mode not found"

This is still a bug and I can't add the label to tag it as such 😔

CSV is wrong when scenarios have different number of warm ups

same version and same issue I think...CSV file has rows w/ varying #columns: ``` scenario,asSync,asSync,asSync,cleanBuild,abiChange version,Gradle 7.4.2,Gradle 7.4.2,Gradle 7.4.2,Gradle 7.4.2,Gradle 7.4.2 tasks,AS sync,AS sync,AS sync,:app:tfa:assembleDefaultDebug,:app:tfa:assembleDefaultDebug value,total execution time,Gradle total execution...

CSV is wrong when scenarios have different number of warm ups

Tried setting the same warm-ups and iterations and something still seems broken. Snippet of gradle scenario file: ``` asSync { android-studio-sync { studio-jvm-args = ["-Xms4g", "-Xmx16g"] warm-ups = 2 iterations...

CSV is wrong when scenarios have different number of warm ups

this fixes the CSV file: ``` asSync { android-studio-sync { studio-jvm-args = ["-Xms4g", "-Xmx16g"] } warm-ups = 1 iterations = 1 } ``` i.e., the #warmups/iterations has to go outside...

CSV is wrong when scenarios have different number of warm ups

ok...setting warmups to 2 and iterations to 3 for all scenarios gives more reasonable results. Looks like AS sync always takes up 5 columns when it should only take up...